-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace obsolete native cell with cell #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balhoff
We have other places in the ShEx where we refer to NativeCell, e.g. CellDivision and CellFateCommitment shapes.
We will need to update those, as well.
Not sure why I missed those! I was searching in the Github UI and for some reason didn't see them. |
Thanks for catching that @vanaukenk, I think I got it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @balhoff
@vanaukenk the CI is failing because we have an instance of calcium oxalate in this test model: https://github.com/geneontology/go-shapes/blob/master/test_ttl/go_cams/should_pass/Test027-has_input_2_MolecularEntity.ttl. Apparently this CHEBI term is not in any of our imports. Not sure why it passed before—maybe at some point we were importing the entire CHEBI? I could just replace the CHEBI term with another. Does that sound reasonable? |
This is what I did, and tests are passing. |
Thanks @balhoff |
CL has obsoleted 'native cell'.