Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete native cell with cell #304

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Replace obsolete native cell with cell #304

merged 4 commits into from
Dec 14, 2023

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Dec 5, 2023

CL has obsoleted 'native cell'.

@balhoff balhoff requested a review from vanaukenk December 5, 2023 16:54
Copy link
Contributor

@vanaukenk vanaukenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balhoff
We have other places in the ShEx where we refer to NativeCell, e.g. CellDivision and CellFateCommitment shapes.
We will need to update those, as well.

@balhoff
Copy link
Member Author

balhoff commented Dec 5, 2023

@balhoff We have other places in the ShEx where we refer to NativeCell, e.g. CellDivision and CellFateCommitment shapes. We will need to update those, as well.

Not sure why I missed those! I was searching in the Github UI and for some reason didn't see them.

@balhoff
Copy link
Member Author

balhoff commented Dec 5, 2023

Thanks for catching that @vanaukenk, I think I got it now.

@balhoff balhoff requested a review from vanaukenk December 5, 2023 17:10
Copy link
Contributor

@vanaukenk vanaukenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @balhoff

@balhoff
Copy link
Member Author

balhoff commented Dec 14, 2023

@vanaukenk the CI is failing because we have an instance of calcium oxalate in this test model: https://github.com/geneontology/go-shapes/blob/master/test_ttl/go_cams/should_pass/Test027-has_input_2_MolecularEntity.ttl. Apparently this CHEBI term is not in any of our imports. Not sure why it passed before—maybe at some point we were importing the entire CHEBI?

I could just replace the CHEBI term with another. Does that sound reasonable?

@balhoff
Copy link
Member Author

balhoff commented Dec 14, 2023

I could just replace the CHEBI term with another. Does that sound reasonable?

This is what I did, and tests are passing.

@balhoff balhoff merged commit cf8ada5 into master Dec 14, 2023
1 check passed
@balhoff balhoff deleted the balhoff-patch-3 branch December 14, 2023 19:34
@vanaukenk
Copy link
Contributor

Thanks @balhoff
I've been on calls most of the afternoon, so sorry I missed this earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants