Skip to content

Commit

Permalink
Merge branch 'master' into update_ontobio
Browse files Browse the repository at this point in the history
  • Loading branch information
sierra-moxon authored Sep 13, 2024
2 parents d2626a6 + 133deb6 commit a09f8e3
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 8 deletions.
10 changes: 6 additions & 4 deletions metadata/rules/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -990,17 +990,19 @@ For the MOD Imports Project into Noctua, it was proposed that group-specific ann
## Object extensions should conform to the extensions-patterns.yaml file in metadata

* id: [GORULE:0000058](https://github.com/geneontology/go-site/blob/master/metadata/rules/gorule-0000058.md)
* status: proposed
* status: implemented


In the go-site/metadata directory there is a file `extensions-constraints.yaml`. This is
Rules are in the `extensions-constraints.yaml` file (https://github.com/geneontology/go-site/blob/master/metadata/extensions-constraints.yaml). This is
a list of allowed extension Relation, Filler (the ID inside the parentheses), and
the acceptable GO Term roots used with this relation. A cardinality constraint may also be
applied.

Extensions in annotations should conform to these constraints. If an element of a
Extensions in annotations should conform to these constraints. If an element of a
disjunction in the extensions does not follow one of the constraints as listed in
the above file, that element should be dropped from the extensions.
the above file, that element is dropped from the extensions with a warning, and the remaining annotation is kept.

Note that in the GO Central pipeline, this is only implmented upon imports of external annotations into Noctua.

<a name="gorule0000059"/>

Expand Down
10 changes: 6 additions & 4 deletions metadata/rules/gorule-0000058.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@ id: GORULE:0000058
title: "Object extensions should conform to the extensions-patterns.yaml file in metadata"
type: repair
fail_mode: hard
status: proposed
status: implemented
tags: [context-import]
contact: "[email protected]"
---
In the go-site/metadata directory there is a file `extensions-constraints.yaml`. This is
Rules are in the `extensions-constraints.yaml` file (https://github.com/geneontology/go-site/blob/master/metadata/extensions-constraints.yaml). This is
a list of allowed extension Relation, Filler (the ID inside the parentheses), and
the acceptable GO Term roots used with this relation. A cardinality constraint may also be
applied.

Extensions in annotations should conform to these constraints. If an element of a
Extensions in annotations should conform to these constraints. If an element of a
disjunction in the extensions does not follow one of the constraints as listed in
the above file, that element should be dropped from the extensions.
the above file, that element is dropped from the extensions with a warning, and the remaining annotation is kept.

Note that in the GO Central pipeline, this is only implmented upon imports of external annotations into Noctua.

0 comments on commit a09f8e3

Please sign in to comment.