-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Python code and GitHub Actions #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use to PEP8 formatting * Add docstrings * Refactor out duplicated code * Use more descriptive method & variable names * Fix typing annotations * Add additional assertions to test * Remove unnecessary printing and file writing in test
* Use to PEP8 formatting * Add docstrings * Remove unused code * Add test for CLI with new dependency for HTTP request mocking * Add additional Minerva object sample for testing
|
kltm
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eyeballing the changes: increasing specificity and detail from the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
These changes are just general tidying up of the initial commit of the repo. They do not represent any significant changes to the
gocam
Python module or CLI functionality.Python code
src/gocam/translation/minerva_wrapper.py
, to make things more readable and/or accurately reflect their purpose.src/gocam/translation/minerva_wrapper.py
.src/gocam/translation/minerva_wrapper.py
.__version__
variable is set and add a CLI option to show the version.Testing
pytest
; previously tests were a mix ofunittest
andpytest
-style tests, while the Makefile was invoking tests via theunittest
module.MinervaWrapper
test; remove unnecessary printing and file writing.gocam.cli
module.Infrastructure
pyproject.toml
; previously it was relying on transitive dependencies brought in bylinkml
.actions/setup-python@v5
.cc: @cmungall