Reject duplicate usernames #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need rebasing after 957ff5e, to become part of |
georgefst
force-pushed
the
duplicate-usernames
branch
from
452d956
to
fee479b
Compare
I guess this case is just slightly too complex for HLint.
Old version is broken because we try to modify the set of users twice. The second time, when opening the websocket, we fail because it's already in the set. So we change our approach to avoid any awkward concurrency issues. We go beyond the original purpose of this PR in that we also defend against differences between the WS and HTTP username params. e.g. if a user modifies the served JS.
Matches `state` and STM stuff. MVars are the outlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't merge this right now since we don't always/ever fire
onDroppedConnectiondue to these issues:ExceptTand parallel composition composewell/streamly#1203 (see the commit message of 95af2c3)Thus we don't actually delete from the set of active users, and therefore if a user tries to reconnect, they'll be rejected as the username will appear to be a duplicate.
Also note that the set is essentially unused in
serverExtWs(even though we initialise it withusers <- newMVar Set.emptysince it's never added to. Perhaps we can refactor.