Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression parsing #228

Merged
merged 14 commits into from
May 26, 2023
Merged

Expression parsing #228

merged 14 commits into from
May 26, 2023

Conversation

KaiVolland
Copy link
Contributor

@KaiVolland KaiVolland commented May 16, 2023

This pull request introduces the Expressions.ts to handle translation between GeoStyler expressions and mapbox expressions.

It also updates geostyer-style to v 7.3.1 and typescript to v 5.0.4.

Compare Expressions.ts L16 or the extended unsupportedProperties object to see which expressions are supported.

❗ tests are currently failing for node <18

@KaiVolland KaiVolland changed the title feat: introduces Expressions.ts Expression parsing May 25, 2023
@KaiVolland KaiVolland marked this pull request as ready for review May 25, 2023 14:22
Copy link

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful how things are coming together!

Copy link
Contributor

@jansule jansule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @KaiVolland! Just some remarks

src/Expressions.ts Outdated Show resolved Hide resolved
src/Expressions.ts Show resolved Hide resolved
src/Expressions.ts Show resolved Hide resolved
src/Expressions.ts Outdated Show resolved Hide resolved
src/MapboxStyleParser.ts Outdated Show resolved Hide resolved
@marcjansen marcjansen deleted the expressions branch May 26, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants