Updated examples in GITBook #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansule
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Thanks for updating the tutorial @Unraveler!
Mainly looks good. There are just a few missing things that should be easy to apply.
| </div> | ||
| ); | ||
| } | ||
|
|
||
| export default App; | ||
| export default App; |
| @@ -5,7 +5,7 @@ Um die `GeoStyler` dependency hinzuzufügen, navigieren Sie bitte (falls noch ni | |||
| Ihres Projektes und führen Sie dort folgenden Befehl aus | |||
|
|
|||
| ```javascript | |||
| npm install geostyler | |||
| npm install geostyler@721 | |||
There was a problem hiding this comment.
Are you not missing the dots between the the different parts of the semver version?
| @@ -13,6 +13,7 @@ wenn sich entweder eine andere Box im Viewport befindet, oder der Style geänder | |||
| olParser | |||
| .writeStyle(newStyle) | |||
| .then(olStyle => { | |||
| console.log(oStyle) | |||
There was a problem hiding this comment.
shouldn't this be
console.log(olStyle.output);
?
| @@ -13,6 +13,7 @@ wenn sich entweder eine andere Box im Viewport befindet, oder der Style geänder | |||
| olParser | |||
| .writeStyle(newStyle) | |||
| .then(olStyle => { | |||
| console.log(oStyle) | |||
| vector.setStyle(olStyle); | |||
There was a problem hiding this comment.
Shouldn't this be
vector.setStyle(olStyle.output);
?
| .readStyle(defaultOlStyle) | ||
| .then(gsStyle => console.log(gsStyle)) | ||
| .then(gsStyle => console.log(gsStyle.output)) | ||
| .catch(error => console.log(error)); |
There was a problem hiding this comment.
The Promise returned by geostyler parsers does not throw errors anymore, so the .catch() part is obsolete
| @@ -90,7 +90,7 @@ function App() { | |||
| olParser | |||
| .writeStyle(newStyle) | |||
| .then(olStyle => { | |||
| vector.setStyle(olStyle); | |||
| vector.setStyle(olStyle.output); | |||
| }) | |||
| .catch(error => console.log(error)); | |||
| @@ -156,7 +156,7 @@ function App() { | |||
| olParser | |||
| .writeStyle(newStyle) | |||
| .then(olStyle => { | |||
| vector.setStyle(olStyle); | |||
| vector.setStyle(olStyle.output); | |||
| }) | |||
| .catch(error => console.log(error)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the examples to be compatibl with latest geostyler version