reverts vscode type upgrade to restore version compatibility #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the automatic upgrade bumped the `@types/vscode` and
`"engines": {"vscode": "^1.63.1"}` which removed all backwards
compatibility
this change can be savely reverted as this extension doesn't
use any newly introduced vscode interfaces
Signed-off-by: Lukas Bockstaller <[email protected]>
chadlwilson
approved these changes
Oct 31, 2023
|
What do you mean by “the automatic upgrade”? |
|
I used https://www.npmjs.com/package/npm-check-updates to update the dependencies, which bumped the vscode types. |
|
Ok, sure. Another reason to keep a ~ on the types, if they are important in this way (and not semver compliant). I imagine it doesn’t touch the engines definition though which is presumably the one which eventually makes it into the VSIX as defining compatibility (although I haven’t looked in depth and not super familiar with vscode extensions) so assume you manually changed that? |
|
Yeah, I am afraid I did upgrade the engine version manually in response to the build error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the automatic upgrade bumped the
@types/vscodeand"engines": {"vscode": "^1.63.1"}which removed all backwards compatibilitythis change can be savely reverted as this extension doesn't use any newly introduced vscode interfaces