-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chrome for testing #2726
Use chrome for testing #2726
Conversation
Hey @NivedhaSenthil . So I was able to make the changes to download chrome for testing and get the functional and unit tests to pass locally after making this commit. a9e87e5 Which means there is an issue with register and hanging on to I am taking a look at it but any pointers will be helpful! |
Let me also check, if I can recollect something 👍 |
@NivedhaSenthil does this have anything to do with https://developer.chrome.com/docs/web-platform/deprecating-unload? I noticed that in the tests the beforeunload event does not fire. |
Apply security fixes Use official repos for downloading Migrate to use typescript Store download urls in package json Use new download url's for browser Re-organize packages Use chrome for testing Update files to refer to the re-organized browser files. Update chrome remote interface Remove old taiko version info Move platform resolution to metadata Append 64 to linux Fix downloadURL usage Initialize metadata globally Use the right platform Add platform append Initialize browser metadata outside constructor Fix typescript versions issues for test Use latest version of mocha Uncomment the close browser test Temporary commit to check behavior Add prettier fomatting rules for windows Add a mocha exit option Upgrade docs test package Commit the functional tests package-lock json file Do clean install to remove local node modules Deprecate beforeunload Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
d1d3554
to
e0ff756
Compare
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Remove docs test on windows Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@saikrishna321 @NivedhaSenthil can you take a look at this PR. The build runs consistently on linux (and mac) which is actually an improvement over previous versions. On windows (check PR description) there are a lot of issues especially with using gauge-ts on versions greater than 16. While the unit tests run correct locally do run they are unpredictable in the CI for windows same is the case with functional tests. I would still recommend bumping up to version 1.4 so that there's a fallback to 1.3. Tell me what you think |
Hi @zabil, sorry for coming back late on this. I think beforeunload event is still not deprecated, From https://developer.chrome.com/docs/web-platform/deprecating-unload. And guess it may be useful to have the api as there may be some sites still using it. And it looks like the event was not triggered for a different reason as mentioned in this blog. Updating the html script in the beforeunload.test.js to below made the tests run fine.
I have the changes locally, can push it if this looks fine. |
Oh thanks! please push the changes if you can. |
Apply security fixes Use official repos for downloading Migrate to use typescript Store download urls in package json Use new download url's for browser Re-organize packages Use chrome for testing Update files to refer to the re-organized browser files. Update chrome remote interface Remove old taiko version info Move platform resolution to metadata Append 64 to linux Fix downloadURL usage Initialize metadata globally Use the right platform Add platform append Initialize browser metadata outside constructor Fix typescript versions issues for test Use latest version of mocha Uncomment the close browser test Temporary commit to check behavior Add prettier fomatting rules for windows Add a mocha exit option Upgrade docs test package Commit the functional tests package-lock json file Do clean install to remove local node modules Deprecate beforeunload Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Remove docs test on windows Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
Signed-off-by: Zabil Cheriya Maliackal <[email protected]> Signed-off-by: Nivedha <[email protected]>
- fix the test by updating the script Signed-off-by: Nivedha <[email protected]>
9b803ea
to
ca255fc
Compare
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
ca255fc
to
32fa9af
Compare
Sorry I am not sure what happened but the commits before unload changes seem to have disappeared after i did a push bumping up the version even though I didn't do a force push. Do you still have the commits? |
@zabil Thank you for contributing to taiko. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
I managed to add the changes back but forgot to sign DCO :/ Trying to rebase is leading to conflicts, should we leave it as such ? |
Yeah. I think it's fine if there are issues. Please feel free to merge if you are ok with the changes. |
I'll take a look at the release pipeline https://github.com/getgauge/taiko/actions/runs/9222743853 |
Fixes: #2708
Notes:
Deprecated beforeunload method because of the following issue
https://developer.chrome.com/docs/web-platform/deprecating-unload
Also gauge-ts does not work on node versions greater than 16 on windows because of this issue
https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2
Our functional tests uses gauge-ts and spawn is used in the launcher
Unfortunately to fix this we'll need big changes to gauge-ts