Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Biome migration #2736

Merged
merged 76 commits into from
Aug 23, 2024
Merged

Biome migration #2736

merged 76 commits into from
Aug 23, 2024

Conversation

zabil
Copy link
Member

@zabil zabil commented Jul 31, 2024

Remove eslint and use biome for formatting a linting to reduce dependencies. Also fix the linting and formatting errors.

Refer #2735

@zabil zabil force-pushed the biome-migration branch from cfb58bf to 4f1417c Compare August 9, 2024 13:10
zabil added 29 commits August 23, 2024 11:07
@zabil
Remove eslint in taiko
534832b 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Functional tests biome migration
8fc68cf 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Apply biome formatting
5c31d54 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Disable linting till errors are fixed
ec19f4b 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Unsafe formatting for actions
f580474 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Optimize attach code to avoid re-assignment
ad159db 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove comma
ccab92e 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove parameter re-assingment
f869825 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Avoid parameter re-assignment
77ff417 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove parameter re-assignment
61a0dea 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Re-define variables
34e738d 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix assignment
1dc0fc4 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Formating changes
ba99d91 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove parameter re-assignment
7de368e 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Do not re-assign options and into
6929d1c 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Rename variables
4849ac5 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix biome suggestions
24d2c75 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Change assignment expression
0b9836f 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
For for of instead of forEach
551b751 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix parameter re-assignment
5cbbaba 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix parameter re-assignment
d20a8da 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix biome suggestions
f8923fd 
Parameter reassignment
foreach loops

Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix biome suggestions
3e41e29 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
More biome suggestions
4ea2e1b 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Use ternary operator
4362624 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Avoid paramater re-assignment
cc01ba7 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Use optional chaining and literal keys
ca45790 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove else clause
af85636 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Ignore Number.isNaN
a377e92 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
zabil added 26 commits August 23, 2024 11:07
@zabil
Avoid parameter re-assignment in open incognito
13c419d 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Do not re-assign paramaters
3d7b6c4 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove paramater re-assignment
a3f9b71 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove paramameter re-assignment for keys
d8cc290 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove parameter re-assignment
8ac2509 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Use function instead of eval
4de9022 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Ignore recommendation
ea93385 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove paramater re-assignment
24302e3 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Optimize dialog handler
ea6e099 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Refactor to avoid paramater re-assignment
6838613 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Refactor to remove re-assignment
ae52037 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove the parameter re-assignment
52548d3 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Format fixes
5b833e8 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove use of eval
6094ae8 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Ignore biome suggestions
4adf177 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Use for of
df43a57 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove paramater re-assignment
acd4d83 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove paramater assignment
57dad3a 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove static methods
aa67d42 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Remove control characters from regex
fd6764c 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix lint issues
429f23c 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Fix lint issues
6900d3d 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Add linting to pipeline
d6e8937 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Ignore folders
0ebb1bd 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Use biome action
c44afba 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil
Ignore api.json formatting
47ce6f9 
Signed-off-by: Zabil Cheriya Maliackal <[email protected]>
@zabil zabil marked this pull request as ready for review August 23, 2024 10:26
@zabil
Copy link
Member Author

zabil commented Aug 23, 2024

This gigantic PR is ready now. I hope it's ok if I merge this. It is mostly formatting and linting changes. I did some testing and there are no major issues. A few deprecation warning for old node api for example

> (node:6633) [DEP0048] DeprecationWarning: The `util.isError` API is deprecated. Please use `ObjectPrototypeToString(e) === "[object Error]" || e instanceof Error` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

Which I feel can be fixed in another PR

@zabil zabil merged commit 0016486 into master Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zabil