Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] PHP 8.4 support #6806

Merged
merged 5 commits into from
Dec 7, 2024
Merged

[v5] PHP 8.4 support #6806

merged 5 commits into from
Dec 7, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Nov 21, 2024

Description

Changelog

Enhancement

  • Support for PHP 8.4

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Nov 21, 2024
@distantnative distantnative added this to the 5.0.0-beta.1 milestone Nov 21, 2024
@distantnative distantnative self-assigned this Nov 21, 2024
@bastianallgeier
Copy link
Member

Is this something we should be doing in 4.5.0 already?

@distantnative
Copy link
Member Author

@bastianallgeier i don't know if this will be ready for 4.5 considering the outstanding support from dependencies.

@bastianallgeier
Copy link
Member

SimpleImage is done. But I guess Pslam could indeed take longer. It's only relevant for CI though.

@distantnative distantnative changed the title PHP 8.4 support [v5] PHP 8.4 support Nov 23, 2024
@distantnative distantnative marked this pull request as ready for review December 7, 2024 13:38
@distantnative distantnative requested a review from a team December 7, 2024 13:38
@distantnative distantnative merged commit cb83501 into v5/develop Dec 7, 2024
12 checks passed
@distantnative distantnative deleted the v5/feature/php-84 branch December 7, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants