Remove OIDC_ENABLED config

.env.template

@@ -30,7 +30,6 @@ HTTPS_PORT=443
 # EMAIL_PASSWORD=
 
 # Optional: configure Single Sign-on with OpenID Connect
-# OIDC_ENABLED=
 # OIDC_DISCOVERY_URL=
 # OIDC_CLIENT_ID=
 # OIDC_CLIENT_SECRET=

docker-compose.yml

@@ -64,7 +64,6 @@ services:
       - EMAIL_IGNORE_TLS=${EMAIL_IGNORE_TLS:-true}
       - EMAIL_USER=${EMAIL_USER:-''}
       - EMAIL_PASSWORD=${EMAIL_PASSWORD:-''}
-      - OIDC_ENABLED=${OIDC_ENABLED:-false}
       - OIDC_DISCOVERY_URL=${OIDC_DISCOVERY_URL:-''}
       - OIDC_CLIENT_ID=${OIDC_CLIENT_ID:-''}
       - OIDC_CLIENT_SECRET=${OIDC_CLIENT_SECRET:-''}
@@ -79,7 +78,9 @@ services:
     build:
       context: .
       args:
-        - OIDC_ENABLED=${OIDC_ENABLED:-false}
+        - OIDC_DISCOVERY_URL=${OIDC_DISCOVERY_URL:-''}
+        - OIDC_CLIENT_ID=${OIDC_CLIENT_ID:-''}
+        - OIDC_CLIENT_SECRET=${OIDC_CLIENT_SECRET:-''}
       dockerfile: nginx.dockerfile
     depends_on:
       - service

files/prebuild/build-frontend.sh

@@ -1,4 +1,8 @@
 #!/bin/bash -eu
 cd client
 npm clean-install --no-audit --fund=false --update-notifier=false
-VUE_APP_OIDC_ENABLED="$OIDC_ENABLED" npm run build
+if [[ -n $OIDC_DISCOVERY_URL && -n $OIDC_CLIENT_ID && -n $OIDC_CLIENT_SECRET ]]; then
+  # shellcheck disable=SC2034
+  VUE_APP_OIDC_ENABLED=true
+fi
+npm run build

files/service/config.json.template

@@ -34,7 +34,6 @@
       "sysadminAccount": "${SYSADMIN_EMAIL}"
     },
     "oidc": {
-      "enabled": ${OIDC_ENABLED},
       "discoveryUrl": "${OIDC_DISCOVERY_URL}",
       "clientId": "${OIDC_CLIENT_ID}",
       "clientSecret": "${OIDC_CLIENT_SECRET}"

files/service/scripts/start-odk.sh

@@ -4,7 +4,7 @@ echo "generating local service configuration.."
 
 ENKETO_API_KEY=$(cat /etc/secrets/enketo-api-key) \
 BASE_URL=$( [ "${HTTPS_PORT}" = 443 ] && echo https://"${DOMAIN}" || echo https://"${DOMAIN}":"${HTTPS_PORT}" ) \
-envsubst '$DOMAIN $BASE_URL $SYSADMIN_EMAIL $ENKETO_API_KEY $DB_HOST $DB_USER $DB_PASSWORD $DB_NAME $DB_SSL $EMAIL_FROM $EMAIL_HOST $EMAIL_PORT $EMAIL_SECURE $EMAIL_IGNORE_TLS $EMAIL_USER $EMAIL_PASSWORD $OIDC_ENABLED $OIDC_DISCOVERY_URL $OIDC_CLIENT_ID $OIDC_CLIENT_SECRET $SENTRY_ORG_SUBDOMAIN $SENTRY_KEY $SENTRY_PROJECT' \
+envsubst '$DOMAIN $BASE_URL $SYSADMIN_EMAIL $ENKETO_API_KEY $DB_HOST $DB_USER $DB_PASSWORD $DB_NAME $DB_SSL $EMAIL_FROM $EMAIL_HOST $EMAIL_PORT $EMAIL_SECURE $EMAIL_IGNORE_TLS $EMAIL_USER $EMAIL_PASSWORD $OIDC_DISCOVERY_URL $OIDC_CLIENT_ID $OIDC_CLIENT_SECRET $SENTRY_ORG_SUBDOMAIN $SENTRY_KEY $SENTRY_PROJECT' \
     < /usr/share/odk/config.json.template \
     > /usr/odk/config/local.json
 

nginx.dockerfile

@@ -1,9 +1,12 @@
-ARG OIDC_ENABLED
 FROM node:18.17 as intermediate
+ARG OIDC_DISCOVERY_URL
+ARG OIDC_CLIENT_ID
+ARG OIDC_CLIENT_SECRET
 
 COPY ./ ./
 RUN files/prebuild/write-version.sh
-RUN OIDC_ENABLED="$OIDC_ENABLED" files/prebuild/build-frontend.sh
+RUN OIDC_DISCOVERY_URL="$OIDC_DISCOVERY_URL" OIDC_CLIENT_ID="$OIDC_CLIENT_ID" OIDC_CLIENT_SECRET="$OIDC_CLIENT_SECRET" \
+  files/prebuild/build-frontend.sh
 
 # when upgrading, look for upstream changes to redirector.conf
 # also, confirm setup-odk.sh strips out HTTP-01 ACME challenge location