Addressed bug where recording requests does not save headers to file. Closes #715 #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheJacobWalters
changed the title
markstory
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a working solution here.
I would welcome feedback on how I can improve this.
I left some comments in my code explaining the main issue I was overcoming. Which is that the headers field of the Request is a unique data structure called ValueView. Writing this data structure to a YAML file created a lot of strange "Tag" artifacts in the file. Therefore I decided that I would need to coerce the data structure into a standard type of Dict. That was harder than I expected and I ended up just parsing the string representation of the ValueView into a Dict. There is probably a better way to do this but I don't know what it is yet.
When this MR is ready to move off of Draft, I can remove those comments.