Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Scripts: add check_update function to helper.sh #3922

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joebonrichie
Copy link
Contributor

Summary

  • for quick anitya monitoring of a single package

Test Plan

source script in environment and run check_update on a bunch of packages

Checklist

  • Package was built and tested against unstable

**Summary**
- for quick anitya monitoring of a single package
@davidjharder
Copy link
Member

How much of a pain is it to write fish and zsh versions?

Seems there is no good way to call a bash function from within the fish shell

@ermo ermo added this to the Solus 4.7 milestone Oct 20, 2024
@ermo ermo added the Topic: Tooling Tools and scripts label Oct 20, 2024
@silkeh
Copy link
Member

silkeh commented Oct 25, 2024

How much of a pain is it to write fish and zsh versions?
Seems there is no good way to call a bash function from within the fish shell

I'd make it a separate script instead and call that from all three helper functions.

Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in itself is sound.

However, it would be way more useful if the actual logic was made into a standalone script, which is then called from the various helper scripts via a function.

Do you have any appetite for doing this rewrite?

@malfisya
Copy link
Member

With ent landing in repository, wouldn't that supersede this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Tooling Tools and scripts
Projects
Status: Needs More Info
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants