Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libstone support in libarchive #4255

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

tarkah
Copy link
Contributor

@tarkah tarkah commented Nov 5, 2024

Summary

Adds support for opening .stone binary files as archives w/ file-roller via libarchive integration

Test Plan

Extracted some archives with file roller

Checklist

  • Package was built and tested against unstable

@ermo ermo changed the title Libstone Add libstone support in libarchive Nov 5, 2024
@ermo ermo marked this pull request as draft November 5, 2024 18:27
@ReillyBrogan
Copy link
Contributor

Some quick feedback for you:

  • the libarchive changes need to be in the form of a patchset that is applied to v3.7.7. I assume they are currently git commits based on libarchive master (we only use release features)
  • the mimetype file should probably be in the Serpent tooling repo
  • please use git format-patch --zero-commit --no-signature to create patches, it zeros out several of the fields and helps reduce patch diff churn a bit
  • there's not really a point in using %apply_patches with only one patch
  • where is the .0.24 soname coming from, do you know?
  • in another PR I have the creation of boulder and moss from a serpent-tools package. I think we probably want to just have one package that builds all tools at once and splits them into subpackages accordingly. I'll probably commandeer this PR to do that myself.

@tarkah tarkah force-pushed the libstone branch 3 times, most recently from 19e90b8 to f399eb8 Compare November 7, 2024 22:19
@tarkah
Copy link
Contributor Author

tarkah commented Nov 7, 2024

where is the .0.24 soname coming from, do you know?

The package symver on the rust package

@ermo ermo marked this pull request as ready for review November 8, 2024 00:01
@ReillyBrogan
Copy link
Contributor

Marking as a draft as the libarchive test suite should really be fixed before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants