Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write/elf: change exported symbols to STV_PROTECTED #588

Closed
wants to merge 1 commit into from
Closed

write/elf: change exported symbols to STV_PROTECTED #588

wants to merge 1 commit into from

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Nov 2, 2023

This allows us to remove the hack to change relocations to use section symbols.

Closes #587

@philipc
write/elf: change exported symbols to STV_PROTECTED
7f7fc8b 
This allows us to remove the hack to change relocations to use
section symbols.
@philipc
Copy link
Contributor Author

philipc commented Nov 2, 2023

I've tested that rustc_codegen_cranelift's test.sh works when running under x86-64 linux.

@philipc
Copy link
Contributor Author

philipc commented Nov 2, 2023

Unfortunately this only works with lld and gold, not bfd.

@philipc
Copy link
Contributor Author

philipc commented Nov 2, 2023

I think this is just replacing one hack with another, so closing.

@philipc philipc closed this Nov 2, 2023
@philipc philipc deleted the issue-587 branch November 2, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write/elf: want_section_symbol is a hack
1 participant
@philipc