Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add m68k arch support #742

Merged
merged 2 commits into from
Nov 8, 2024
Merged

add m68k arch support #742

merged 2 commits into from
Nov 8, 2024

Conversation

knickish
Copy link
Contributor

@knickish knickish commented Nov 7, 2024

The M68k values were already included, this PR adds the enum Architecture entry for M68k and fills out the relevant match statements

Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update

fn parse_relocation<Elf: FileHeader>(
and
fn elf_any() {

src/write/elf/object.rs Outdated Show resolved Hide resolved
@knickish knickish marked this pull request as draft November 8, 2024 03:52
@knickish
Copy link
Contributor Author

knickish commented Nov 8, 2024

Thanks, had missed those functions. I believe I've gotten everything and matched the formatting.

@knickish knickish marked this pull request as ready for review November 8, 2024 04:14
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit fb4446b into gimli-rs:master Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants