Initial SHT_RELR support #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now we just pass the data through unmodified. In the future, we may need to parse the relocations (e.g. to update relocations for sections that have been changed).
This is still missing an encoder for the relocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a low level API for reading
SHT_RELRrelocations, and changes the ELF builder to copy the section.This doesn't add the relocations to the
read::Objecttrait. It's not clear what the best way to support this is. Adding them intoObject::dynamic_relocationswould require synthesizing fields of theRelocation. An alternative is to add a new method, and perhaps this method could cover PE base relocations (which are also not currently handled by theread::Objecttrait). This can wait until someone has a use case for these so that it can be tested properly.In the future, the ELF builder may need to support modifying the relocations. The difficulty with this is that the relocations would need to be encoded again before doing layout. Again, this can wait until someone has a use case for this. This is the same as the existing support for various other sections.
Closes #722, closes #744 (cc @bjorn3, @fg-scontain)