Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Gin recovery middleware for performance and readability #4050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize Gin recovery middleware for performance and readability #4050

wants to merge 1 commit into from

Conversation

dougtu
Copy link

@dougtu dougtu commented Sep 5, 2024

Optimize Gin recovery middleware for performance and readability

  • Cache file contents to avoid redundant file reads during stack trace generation.
  • Extract header sanitization logic into a separate function sanitizeHeaders for better code reuse and clarity.
  • Parallelize log printing using goroutines to improve performance under high concurrency.
  • Refactor code to reduce redundancy and improve maintainability.

@appleboy
Copy link
Member

Please provide the performance report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougtu @appleboy