Reduce duplicate computation of expensive cached values. #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some item functions are cached, like histograms, tile frames, and thumbnails. These can be expensive. Before, if a client asked for an expensive function and a second client asked for the same function before the first completed, it would compute it twice. Now, the second call waits for the first to complete and then reads from the cache.
manthey
added a commit
that referenced
this pull request
Apr 10, 2023
manthey
added a commit
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some item functions are cached, like histograms, tile frames, and thumbnails. These can be expensive. Before, if a client asked for an expensive function and a second client asked for the same function before the first completed, it would compute it twice. Now, the second call waits for the first to complete and then reads from the cache.