Make CI testing compatible with large image and girder 5 #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naglepuff
force-pushed
the
girder-5-tox
branch
from
fcb7706 to
d89bffe
Compare
naglepuff
changed the title
Also use node 16, since that is what is used by the current girder_test image.
Ensure that it works with the `girder` global and ignores the `dist/` directory.
Adding this primarily as a stopgap. It might be worthwhile to go back and clean this issues up before merging the Girder 5 branch.
naglepuff
force-pushed
the
girder-5-tox
branch
from
067fdfe to
6f77174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1. Changes to
toxconfig and environmentsSince the
girder buildcommand is being removed from Girder 5, that command has been removed from thetox.iniconfiguration. Since client tests are being migrated to playright, the existing python files that invoke client tests have been removed.Additionally, a new requirements file,
requirements-girder5.txthas been created and uses--preto ensure that all of the Girder-adjacent requirements are installed using the correct (development/prerelease) versions.2. Changes to Circle CI config
A new step has been added under
allserviceswhich will build the client code. This was necessary since the register plugin code relies on certain files (geojs.js) being available in thedist/folder.Node v16 is used for all of the tests. Version 16 was chosen because it matches the version used in the testing environment for Girder'sDuring discussion about these changes, it was decided to use Node 20.v4-integrationbranch.3. Linting and formatting
For client-side linting, everything in
dist/will be ignored by the linter. Also, thegirderglobal has been added to theeslintconfig. Client side files were also formatted usingtox -e formatclient.The python linting config has been updated to ignore error codes G002 and G004 (using f-strings in log statements and using '%' in log statements). I'm willing to re-enable those error codes and fix the 30ish places in the code where they occur if that is worth the added effort here.
4. Miscellaneous changes
girder. These have been fixed.zarris now pinned tozarr<3due to some refactoring of stores (see the link insources/zarr/setup.py).TODO before review/merge