Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat mount point as symlink-like in finddata2dirent #4383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Treat mount point as symlink-like in finddata2dirent #4383

wants to merge 1 commit into from
+23 −1

Commits on Apr 14, 2023

  1. Treat mount point as symlink-like in finddata2dirent 

    Testing on a pnpm monorepo containing recursive symlinks, it turns out
that dwReserved0 is actually IO_REPARSE_TAG_MOUNT_POINT.

Checking FILE_ATTRIBUTE_REPARSE_POINT and IO_REPARSE_TAG_MOUNT_POINT
appears to match similar code in mingw.c's mingw_is_mount_point.

The new test fails without this change, but I am unsure whether or not
it needs some sort of conditional that checks that symlinks are
available in Windows. "SYMLINK" used in the test file appears to be
false even though I have developer mode enabled, allowing them.

Signed-off-by: Jake Bailey <[email protected]>
    @jakebailey
    jakebailey committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    482d952 View commit details
    Browse the repository at this point in the history