Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiselect display bug for selects not using multiselect #729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ambischof
Copy link
Contributor

@ambischof ambischof commented Oct 30, 2019

If you had multiselect library loaded, but were not using it for a sepecific select, then you disable/enable it, it would switch from normal select to multiselect.

I mimiced the logic used elsewhere to decide whether or not to render multiselect, which is whether or not the 'multiple' option was set.

see jsfiddle https://jsfiddle.net/anneb574/rhce3oxf/2/

If you had multiselect library loaded, but were not using it for a sepecific select, then you disable/enable it, it would switch from normal select to multiselect.

I mimiced the logic used elsewhere to decide whether or not to render multiselect, which is whether or not the 'multiple' option was set.

see jsfiddle https://jsfiddle.net/anneb574/rhce3oxf/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant