JS: Merge 'main' and implement 'speculativeTaintStep' #18044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a mandatory part of the interface now; just providing a bare-bones implementation for rather than 'none()'
This was removed as part of the PR that introduced threat models.
asgerf
force-pushed
the
js/shared-dataflow-bump
branch
from
0194353
to
8818fcc
Compare
|
The QLDoc Check failure can be ignored as the target branch contains an unfixed merge commit which doesn't compile by itself. |
erik-krogh
approved these changes
Nov 27, 2024
asgerf
merged commit 66d6bda
into
github:js/shared-dataflow-merge-main
7 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speculativeTaintStepis a mandatory part of the data flow interface now, resulting in compilation errors when merging inmain.It's not a priority to get this working, so just providing a bare-bones implementation that's slightly better than
none().