Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SecureTemporaryFiles with an EphemeralFile implementation based on ChaCha20 #4367

Closed
wants to merge 2 commits into from

Conversation

evilaliv3
Copy link
Member

With this pull request i would like to propose:

  • Replacement of SecureTemporaryFiles based on AES with EphemeralFile based on ChaCha20
  • Addition of the globaleaks-eph-fs command that we might use to instantiate an ephemeral filesystem when integrating ClamAV and MAT2

@evilaliv3 evilaliv3 requested a review from a team as a code owner December 30, 2024 19:39
@evilaliv3
Copy link
Member Author

@msmannan00 : When you like please feel free to proceed with the review of this pull request.

Copy link

codacy-production bot commented Dec 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-69.70% (target: +0.50%) 4.39% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (852b292) 19236 16038 83.37%
Head commit (46abef2) 28738 (+9502) 3930 (-12108) 13.68% (-69.70%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4367) 433 19 4.39%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@evilaliv3 evilaliv3 force-pushed the feature/ephemeral-fs branch from 5e8c2d7 to 46abef2 Compare December 30, 2024 19:45
@evilaliv3
Copy link
Member Author

Actually i missed to add the libraries! Going to fix it fist before opening for review.

Thank you!

@evilaliv3 evilaliv3 closed this Dec 30, 2024
@msmannan00
Copy link
Member

Yes will do so thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants