Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type to Select improvements #32

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Type to Select improvements #32

merged 4 commits into from
Jul 15, 2024

Conversation

rmottola
Copy link
Member

#31

rmottola added 3 commits June 25, 2024 17:34
…uding it, and as fallback before it. Handle no-selection just with a skip.
- if appended buffer matches fine, else use the typed character to start a new selection
- shorten time for one-word to 5 seconds (should be unified into a constant or preference)
- while a character doesn't match any beginning, keep re-initing
- allow exiting word-typing with esc
@rmottola rmottola self-assigned this Jun 27, 2024
@rmottola
Copy link
Member Author

rmottola commented Jul 2, 2024

@rfm @fredkiefer how would you call this "type select" behaviour? maybe I can rename some of the related variables better, I already tried a little bit.
typeSelect is what I would use currently.

@rmottola rmottola requested a review from fredkiefer July 2, 2024 22:00
@rmottola
Copy link
Member Author

rmottola commented Jul 2, 2024

@eukara this works starts from your "Escape" patch, so if you care to test or comment on it, welcome.

@eukara
Copy link

eukara commented Jul 8, 2024

Testing it now.

@eukara
Copy link

eukara commented Jul 11, 2024

All good on my end.

@rmottola
Copy link
Member Author

Thank you, @eukara

@rmottola rmottola merged commit 6179503 into master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants