Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] CI: Partially sync workflows and actions with 3.x branch #98938

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Nov 7, 2024

Differences to 3.x:

  • All: Stick to ubuntu:20.04 runners for now, as porting to newer ones implies fixing a number of compilation warnings which may not be worth the trouble for an EOL branch
  • All: Keep 3.4 base branch
  • Build: Keep the --jobs=2 SCons argument, 3.4 and earlier don't have the auto job count detection
  • Android: Keep Java 11
  • Web: Keep Emscripten 2.0.25
  • Linux: Don't add the minimal template build, which relies on a number of fixes and improvements not made in that branch
  • Static checks:
    • Update to ubuntu:22.04 instead of ubuntu:24.04 so we can pin clang-format-13 instead of 16, keeping the same version as prior, so we don't have to do style changes to this EOL branch
    • Don't add the gitignore_check.sh static check as we didn't do the fixes it helps enforce
    • Don't add the class reference schema static check as we didn't backport that either
    • Keep previous copyright_header.py, as we didn't do the big copyright update to "present" in 3.4 and earlier
    • Keep previous clang_format.sh with needed exceptions for some .java files

@akien-mga akien-mga added this to the 3.4 milestone Nov 7, 2024
@akien-mga akien-mga requested review from a team as code owners November 7, 2024 21:28
@akien-mga akien-mga force-pushed the 3.4-ci-sync-with-3.x branch 4 times, most recently from e5e5c32 to 3b46d31 Compare November 7, 2024 21:50
@akien-mga akien-mga changed the title [3.4] CI: Fully sync workflows and actions with 3.x branch [3.4] CI: Partially sync workflows and actions with 3.x branch Nov 7, 2024
@akien-mga akien-mga force-pushed the 3.4-ci-sync-with-3.x branch 3 times, most recently from 8af3dff to 8f73770 Compare November 7, 2024 22:08
Stick to `ubuntu:20.04` runners for now, as porting to newer ones implies
fixing a number of compilation warnings which may not be worth the trouble
for an EOL branch.

Static checks do use `ubuntu:22.04` as it comes with clang-format 13 out
of the box, so we avoid having to install it.
@akien-mga akien-mga merged commit f92989c into godotengine:3.4 Nov 8, 2024
13 checks passed
@akien-mga akien-mga deleted the 3.4-ci-sync-with-3.x branch November 8, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants