Hide menu BackgroundCache node to fully benefit from async. pipeline compilation #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
aaronfranke
approved these changes
Sep 23, 2024
|
This doesn't seem quite correct. In theory the real effective way is that this trick is no longer required. I'll verify if this is the case by deleting the node altogether. |
|
These are actually what need to be done on the PR.
|
…compilation This was an attempt by the game to cache the pipelines ahead of time for the bullet. However, the title screen does not use SDFGI or VoxelGI, so the ubershader pipeline pre-compilation is not detecting it should create these pipelines. The extra two to four pipelines we're seeing on the first shot are the new pipelines encountered due to the fact the effect only gets enabled when starting the game, but the instancing of this bullet ahead of time is not done there instead. Merely instancing the bullet scene as hidden fixes this issue immediately, as hidden surfaces are added to the cache.
Calinou
force-pushed
the
use-async-pipeline-compilation
branch
from
39b652f
to
e80c507
Compare
I've applied all 3 suggestions. |
|
I can confirm the latest version works as intended. 👍 |
|
godotengine/godot#90400 is merged, so we can go ahead with this as well. |
emrecrpnl
pushed a commit
to emrecrpnl/tps-demo
that referenced
this pull request
Oct 8, 2024
…compilation (godotengine#191) This was an attempt by the game to cache the pipelines ahead of time for the bullet. However, the title screen does not use SDFGI or VoxelGI, so the ubershader pipeline pre-compilation is not detecting it should create these pipelines. The extra two to four pipelines we're seeing on the first shot are the new pipelines encountered due to the fact the effect only gets enabled when starting the game, but the instancing of this bullet ahead of time is not done there instead. Merely instancing the bullet scene as hidden fixes this issue immediately, as hidden surfaces are added to the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation courtesy of @DarioSamo:
This was an attempt by the game to cache the pipelines ahead of time for the bullet. However, the title screen does not use SDFGI or VoxelGI, so the ubershader pipeline pre-compilation is not detecting it should create these pipelines.
The extra two to four pipelines we're seeing on the first shot are the new pipelines encountered due to the fact the effect only gets enabled when starting the game, but the instancing of this bullet ahead of time is not done there instead.
Merely instancing the bullet scene as hidden fixes this issue immediately, as hidden surfaces are added to the cache.
A side effect of this change is that
menu.tscnno longer needs to store a lot of properties, so it becomes a lot smaller and should load faster too.This change requires Godot 4.4 (
masterbranch).