Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 feat: Add support for CBOR encoding #3173
🔥 feat: Add support for CBOR encoding #3173
Changes from all commits
7f7fb38
ea59267
db00468
84c71a5
ba23305
7ee9548
ae8407c
988fd26
b316b36
a8192d1
2b11150
90f6ae8
4be558c
697243b
6dfc59f
23ef579
99f9893
190704a
e397dc2
a12cad3
a1f2dff
ef215f3
602ae7a
fc1779b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Documentation needs CBOR usage examples.
To maintain consistency with other binder documentation, please add CBOR usage examples similar to the existing JSON and XML examples. This should include:
Here's a suggested addition after the existing examples:
Also consider adding a complete CBOR example:
You can test this endpoint using a tool that supports CBOR, or using Python with the cbor2 library:
The
Body()
method automatically handles CBOR content when theContent-Type
header is set toapplication/cbor
.Check warning on line 12 in binder/cbor.go
Codecov / codecov/patch
binder/cbor.go#L11-L12
Check warning on line 17 in binder/cbor.go
Codecov / codecov/patch
binder/cbor.go#L16-L17
Check warning on line 54 in binder/mapping.go
Codecov / codecov/patch
binder/mapping.go#L54