singleflight: add per caller function #20
Draft
+144
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to the proposal in #9, inspired by @bcmills' comment.
The general idea is to add a second function argument to
Do
, which is guaranteed to be called by all goroutines waiting on a singleflight before the singleflighted call returns. It complements the existing function argument so that writing code that must be called in all cases becomes trivial.Some refactoring to reduce code duplication could also be done, but I wanted to get some first working version out to kickstart a discussion.
Names are of course up for bikeshedding.
WDYT?