Keep original functions paths (#13)

Fixes #12
goldwasserexchange · May 17, 2017 · ed1e526 · ed1e526
1 parent 291e44e
commit ed1e526
Show file tree

Hide file tree

Showing 8 changed files with 45 additions and 51 deletions.
diff --git a/src/index.js b/src/index.js
@@ -46,13 +46,11 @@ class ServerlessPluginWebpack {
     // Package individually and exclude everything at the service level
     this.serverless.service.package = {
       individually: true,
-      exclude: ['*'],
+      exclude: ['**'],
     };
 
-    // Include bundle and update handler at function level
-    this.serverless.service.functions = functions.setPackageAndHandler(
-      this.serverless.service.functions
-    );
+    // Include bundle at function level
+    this.serverless.service.functions = functions.setPackage(this.serverless.service.functions);
 
     // Run webpack
     return wpack.run(

diff --git a/src/lib/functions.js b/src/lib/functions.js
@@ -1,27 +1,12 @@
 const path = require('path');
 const R = require('ramda');
-const list = require('./list');
-
-const handlerProp = R.prop('handler');
 
 const handlerPath = R.replace(/\.[^.]+$/, '.js');
-const handlerFile = R.compose(path.basename, handlerPath);
-const fnPath = R.compose(handlerPath, handlerProp);
-const fnFilename = R.compose(handlerFile, handlerProp);
-
-const setPackage = fn =>
-  R.assoc(
-    'package',
-    R.objOf(
-      'include',
-      R.compose(list, fnFilename)(fn)
-    ),
-    fn
-  );
+const fnPath = R.compose(handlerPath, R.prop('handler'));
 
-const setHandler = R.over(R.lensProp('handler'), path.basename);
+const fnInclude = fn => R.objOf('include', [fnPath(fn)]);
 
-const setPackageAndHandler = R.map(R.compose(setHandler, setPackage));
+const setPackage = R.map(fn => R.assoc('package', fnInclude(fn), fn));
 
 const setArtifacts = (serverlessPath, fns) => R.map(
   R.over(
@@ -33,7 +18,6 @@ const setArtifacts = (serverlessPath, fns) => R.map(
 
 module.exports = {
   fnPath,
-  fnFilename,
-  setPackageAndHandler,
+  setPackage,
   setArtifacts,
 };
diff --git a/src/lib/list.js b/src/lib/list.js
diff --git a/src/lib/wpack.js b/src/lib/wpack.js
@@ -13,7 +13,7 @@ const setEntry = (fn, servicePath) =>
   R.assoc(
     'entry',
     R.objOf(
-      functions.fnFilename(fn),
+      functions.fnPath(fn),
       path.join(servicePath, functions.fnPath(fn))
     )
   );

diff --git a/test/fns.js b/test/fns.js
@@ -1,11 +1,18 @@
 const originalFns = {
-  get: {
+  firstGet: {
     handler: 'functions/first/get.handler',
     package: {
       include: ['*'],
       exclude: ['abc.js'],
     },
   },
+  secondGet: {
+    handler: 'functions/second/get.handler',
+    package: {
+      include: ['*'],
+      exclude: ['abc.js'],
+    },
+  },
   post: {
     handler: 'functions/post.handler',
     package: { exclude: ['*.js'] },

diff --git a/test/functions.test.js b/test/functions.test.js
@@ -3,36 +3,38 @@ const functions = require('../src/lib/functions');
 const fns = require('./fns.js');
 
 const modifiedFns = {
-  get: {
-    handler: 'get.handler',
-    package: { include: ['get.js'] },
+  firstGet: {
+    handler: 'functions/first/get.handler',
+    package: { include: ['functions/first/get.js'] },
+  },
+  secondGet: {
+    handler: 'functions/second/get.handler',
+    package: { include: ['functions/second/get.js'] },
   },
   post: {
-    handler: 'post.handler',
-    package: { include: ['post.js'] },
+    handler: 'functions/post.handler',
+    package: { include: ['functions/post.js'] },
   },
 };
 
 const artifactFns = {
-  get: { artifact: '/.serverless/.webpack/service-dev-get.zip' },
+  firstGet: { artifact: '/.serverless/.webpack/service-dev-firstGet.zip' },
+  secondGet: { artifact: '/.serverless/.webpack/service-dev-secondGet.zip' },
   post: { artifact: '/.serverless/.webpack/service-dev-post.zip' },
 };
 
 const modifiedArtifactFns = {
-  get: { artifact: path.join('/.serverless', 'service-dev-get.zip') },
+  firstGet: { artifact: path.join('/.serverless', 'service-dev-firstGet.zip') },
+  secondGet: { artifact: path.join('/.serverless', 'service-dev-secondGet.zip') },
   post: { artifact: path.join('/.serverless', 'service-dev-post.zip') },
 };
 
 test('fnPath', () => {
-  expect(functions.fnPath(fns.get)).toBe('functions/first/get.js');
-});
-
-test('fnFilename', () => {
-  expect(functions.fnFilename(fns.post)).toBe('post.js');
+  expect(functions.fnPath(fns.firstGet)).toBe('functions/first/get.js');
 });
 
-test('setPackageAndHandler', () => {
-  expect(functions.setPackageAndHandler(fns)).toEqual(modifiedFns);
+test('setPackage', () => {
+  expect(functions.setPackage(fns)).toEqual(modifiedFns);
 });
 
 test('setArtifacts', () => {

diff --git a/test/list.test.js b/test/list.test.js
diff --git a/test/wpack.test.js b/test/wpack.test.js
@@ -18,7 +18,7 @@ const folder = '.webpack';
 const configs = [
   {
     entry: {
-      'get.js': path.join(servicePath, 'functions/first/get.js'),
+      'functions/first/get.js': path.join(servicePath, 'functions/first/get.js'),
     },
     output: {
       libraryTarget: 'commonjs2',
@@ -29,7 +29,18 @@ const configs = [
   },
   {
     entry: {
-      'post.js': path.join(servicePath, 'functions/post.js'),
+      'functions/second/get.js': path.join(servicePath, 'functions/second/get.js'),
+    },
+    output: {
+      libraryTarget: 'commonjs2',
+      path: path.join(servicePath, folder),
+      filename: '[name]',
+    },
+    externals: [/aws-sdk/],
+  },
+  {
+    entry: {
+      'functions/post.js': path.join(servicePath, 'functions/post.js'),
     },
     output: {
       libraryTarget: 'commonjs2',