Fix ctor std thread init (#874)

* clippy * remove printlns from ctors * clippy
golemcloud · Sep 6, 2024 · 4acacec · 4acacec
1 parent c02bf96
commit 4acacec
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 15 deletions.
diff --git a/golem-common/src/tracing.rs b/golem-common/src/tracing.rs
@@ -399,9 +399,7 @@ where
         })
     });
 
-    if config.dtor_friendly {
-        println!("Tracing initialized, config: {:?}", config);
-    } else {
+    if !config.dtor_friendly {
         info!(
             // NOTE: intentionally logged as string and not as structured
             tracing_config = serde_json::to_string(&config).expect("cannot serialize log config"),

diff --git a/golem-test-framework/src/components/k8s.rs b/golem-test-framework/src/components/k8s.rs
@@ -436,7 +436,7 @@ impl Routing {
         loop {
             let mut child = Command::new("minikube")
                 .arg("service")
-                .arg(&format!("--namespace={}", namespace.0))
+                .arg(format!("--namespace={}", namespace.0))
                 .arg("--url")
                 .arg(service_name)
                 .stdout(Stdio::piped())
@@ -492,7 +492,7 @@ impl Routing {
         loop {
             let output = Command::new("minikube")
                 .arg("service")
-                .arg(&format!("--namespace={}", namespace.0))
+                .arg(format!("--namespace={}", namespace.0))
                 .arg("--url")
                 .arg(service_name)
                 .output()

diff --git a/integration-tests/src/benchmarks/mod.rs b/integration-tests/src/benchmarks/mod.rs
@@ -176,15 +176,15 @@ pub async fn benchmark_invocations(
                     result.retries as u64,
                 );
                 recorder_clone.count(
-                    &ResultKey::secondary(&format!("{prefix_clone}worker-{n}-retries")),
+                    &ResultKey::secondary(format!("{prefix_clone}worker-{n}-retries")),
                     result.retries as u64,
                 );
                 recorder_clone.count(
                     &format!("{prefix_clone}invocation-timeouts").into(),
                     result.timeouts as u64,
                 );
                 recorder_clone.count(
-                    &ResultKey::secondary(&format!("{prefix_clone}worker-{n}-timeouts")),
+                    &ResultKey::secondary(format!("{prefix_clone}worker-{n}-timeouts")),
                     result.timeouts as u64,
                 );
             }

diff --git a/integration-tests/tests/lib.rs b/integration-tests/tests/lib.rs
@@ -34,10 +34,6 @@ pub static DEPS: EnvBasedTestDependencies = {
     let deps = EnvBasedTestDependencies::blocking_new_from_worker_executor_cluster_size(3);
 
     deps.redis_monitor().assert_valid();
-    println!(
-        "Started a cluster of {} worker executors",
-        deps.worker_executor_cluster().size()
-    );
 
     deps
 };

diff --git a/integration-tests/tests/sharding.rs b/integration-tests/tests/sharding.rs
@@ -671,10 +671,6 @@ pub static DEPS: EnvBasedTestDependencies = {
     });
 
     deps.redis_monitor().assert_valid();
-    println!(
-        "Started a cluster of {} worker executors",
-        deps.worker_executor_cluster().size()
-    );
 
     deps
 };