Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ctor std thread init #874

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix ctor std thread init #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb7e81
clippy
noise64 Sep 6, 2024
51a460b
remove printlns from ctors
noise64 Sep 6, 2024
7a7fe93
clippy
noise64 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions golem-common/src/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,7 @@ where
})
});

if config.dtor_friendly {
println!("Tracing initialized, config: {:?}", config);
} else {
if !config.dtor_friendly {
info!(
// NOTE: intentionally logged as string and not as structured
tracing_config = serde_json::to_string(&config).expect("cannot serialize log config"),
Expand Down
4 changes: 2 additions & 2 deletions golem-test-framework/src/components/k8s.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ impl Routing {
loop {
let mut child = Command::new("minikube")
.arg("service")
.arg(&format!("--namespace={}", namespace.0))
.arg(format!("--namespace={}", namespace.0))
.arg("--url")
.arg(service_name)
.stdout(Stdio::piped())
Expand Down Expand Up @@ -492,7 +492,7 @@ impl Routing {
loop {
let output = Command::new("minikube")
.arg("service")
.arg(&format!("--namespace={}", namespace.0))
.arg(format!("--namespace={}", namespace.0))
.arg("--url")
.arg(service_name)
.output()
Expand Down
4 changes: 2 additions & 2 deletions integration-tests/src/benchmarks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,15 @@ pub async fn benchmark_invocations(
result.retries as u64,
);
recorder_clone.count(
&ResultKey::secondary(&format!("{prefix_clone}worker-{n}-retries")),
&ResultKey::secondary(format!("{prefix_clone}worker-{n}-retries")),
result.retries as u64,
);
recorder_clone.count(
&format!("{prefix_clone}invocation-timeouts").into(),
result.timeouts as u64,
);
recorder_clone.count(
&ResultKey::secondary(&format!("{prefix_clone}worker-{n}-timeouts")),
&ResultKey::secondary(format!("{prefix_clone}worker-{n}-timeouts")),
result.timeouts as u64,
);
}
Expand Down
4 changes: 0 additions & 4 deletions integration-tests/tests/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ pub static DEPS: EnvBasedTestDependencies = {
let deps = EnvBasedTestDependencies::blocking_new_from_worker_executor_cluster_size(3);

deps.redis_monitor().assert_valid();
println!(
"Started a cluster of {} worker executors",
deps.worker_executor_cluster().size()
);

deps
};
Expand Down
4 changes: 0 additions & 4 deletions integration-tests/tests/sharding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,6 @@ pub static DEPS: EnvBasedTestDependencies = {
});

deps.redis_monitor().assert_valid();
println!(
"Started a cluster of {} worker executors",
deps.worker_executor_cluster().size()
);

deps
};
Expand Down
Loading