Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Language Dropdown & Search Narrow Display Issue + Farsi Font Update #2057

Closed
wants to merge 4 commits into from

Conversation

poursalavati
Copy link

@poursalavati poursalavati commented Jul 24, 2024

This pull request addresses two user interface issues:

Language Dropdown and Search Box in Narrow Display: Fixes the issue reported in #2035 and #1944 where the language dropdown menu (and search box) become inaccessible on narrow displays.

Farsi Font Update: Updates the Farsi font to the open-source Vazirmatn from Google Fonts. This improves compatibility and potentially resolves issues encountered with previous Vazir font implementations.

PS:
The PR has been updated to resolve an issue affecting the dark/light menu on medium and small screens. The updated code ensures consistent menu functionality across all screen dimensions:

Demo: https://deploy-preview-2057--docsydocs.netlify.app/
Multi-lingual demo: https://rdrp.ir

Before:

After:

Farsi Font correction + Dropdown menu

Copy link

google-cla bot commented Jul 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@poursalavati poursalavati marked this pull request as draft July 31, 2024 18:23
@poursalavati poursalavati marked this pull request as ready for review July 31, 2024 19:14
@poursalavati
Copy link
Author

Fixed a minor bug.

@chalin
Copy link
Collaborator

chalin commented Oct 17, 2024

HI @poursalavati, thanks for your PR. Note that Docy's RTL support has been upgraded, for details see:

So I'm unsure which parts of this PR are still relevant. I'm going to close this for now. Feel free to resubmit PRs -- I strongly suggest submitted separate PRs for each issue resolved. If you aren't able, I'll revisit this PR later when I have the time. Thanks!

@chalin chalin closed this Oct 17, 2024
@chalin chalin mentioned this pull request Oct 17, 2024
25 tasks
@chalin chalin mentioned this pull request Nov 6, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants