Clarify usage of "title" with embeddings. #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
status:awaiting review
pcoet
reviewed
Mar 11, 2024
| @@ -141,7 +141,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
markmcd
reviewed
Mar 12, 2024
| @@ -141,7 +141,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Can we say more than "affects the embedding"?
e.g. something like "Separating the title from the content ensures your content is modeled correctly when calculating similarity scores." and also "To ensure reliable results, include or omit the title consistently across your corpus."
@sidgoogle gave me a quick review on these claims :)
Reply via ReviewNB
|
Friendly ping. |
|
I'll approve to unblock you, but did you see the comments? |
pcoet
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.