Add annotation to allow passthrough default methods on assisted factories #1760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345
Add
@PassthroughDefaultMethods
annotation to allow using default methods on assisted factories (but only when explicitly requested by the user, see #1347 (comment))As mentioned in the linked comment, we don't want to change existing behavior in case anyone is relying on it. So instead we add an annotation to specify what behavior we want. If the annotation was only able to be placed on individual methods, a more generic name like
@Unassisted
might be ok, however since I am also allowing the annotation on factory interfaces, I felt a more specific name made sense.