fix info and setting fragment profile menu item click #359

kareemradwan · 2020-09-11T23:00:53Z

I fixed the bug in Profile Menu Item Click in Info and Setting Fragments

google-cla · 2020-09-11T23:00:57Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

kareemradwan · 2020-09-11T23:03:26Z

@googlebot I signed it!

jdkoren

Thanks! Just a few nits: there are some lines with whitespace changes and one with a new line-break. These aren't necessary and don't follow the existing style in the affected files.

We have a code style in tools/iosched-codestyle.xml, you can import this in Android studio and use it for this project and that should take care of the formatting.

kareemradwan · 2020-09-11T23:35:05Z

@jdkoren
sure. I will do it

kareemradwan · 2020-09-13T07:17:15Z

@jdkoren can you review the code?

jdkoren · 2020-09-14T14:53:47Z

tools/iosched-codestyle.xml

-      <option name="CONTINUATION_INDENT_SIZE" value="4" />
-    </indentOptions>
-  </codeStyleSettings>
+<code_scheme name="iosched"


This file is not source code and should not be formatted as such (it is never edited directly). Please revert.

jdkoren · 2020-09-15T18:32:31Z

.gitignore

@@ -39,3 +39,4 @@ _sandbox

 # Android Studio captures folder
 captures/
+tools/iosched-codestyle.xml


This file is not supposed to be ignored. We check it in so that others (like yourself) can use the same code style when contributing to the project. Please revert this change and revert the changes to that file.

This line still needs to be removed.

jdkoren · 2020-10-23T20:22:05Z

mobile/src/main/java/com/google/samples/apps/iosched/ui/info/InfoFragment.kt

-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
+            inflater: LayoutInflater,


Please undo these whitespace changes

jdkoren · 2020-10-23T20:22:31Z

mobile/src/main/java/com/google/samples/apps/iosched/ui/info/InfoFragment.kt

-            R.string.event_title,
-            R.string.travel_title,
-            R.string.faq_title
+                R.string.event_title,


Please undo these whitespace changes

jdkoren · 2020-10-23T20:22:43Z

mobile/src/main/java/com/google/samples/apps/iosched/ui/settings/SettingsFragment.kt

-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
+            inflater: LayoutInflater,


Please undo these whitespace changes

jdkoren · 2020-10-23T20:22:54Z

mobile/src/main/java/com/google/samples/apps/iosched/ui/settings/SettingsFragment.kt

-            .setView(webView)
-            .create()
-            .show()
+                .setTitle(dialogTitle)


Please undo these whitespace changes

jdkoren · 2020-10-23T20:25:18Z

.gitignore

@@ -39,3 +39,4 @@ _sandbox

 # Android Studio captures folder
 captures/
+tools/iosched-codestyle.xml


This line still needs to be removed.

fix info and setting fragment profile menu item click

6b377dd

google-cla bot added the cla: no label Sep 11, 2020

google-cla bot added cla: yes and removed cla: no labels Sep 11, 2020

jdkoren suggested changes Sep 11, 2020

View reviewed changes

fix code style issue

fcacad1

kareemradwan requested a review from jdkoren September 11, 2020 23:50

applied google code style to project

497e9fd

jdkoren suggested changes Sep 14, 2020

View reviewed changes

add code-style file in gitIgnore

220bea8

jdkoren suggested changes Sep 15, 2020

View reviewed changes

remove iosched-codestyle from gitIgnore and apply google style

beccb0d

jdkoren reviewed Oct 23, 2020

View reviewed changes

Base automatically changed from master to main February 11, 2021 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix info and setting fragment profile menu item click #359

fix info and setting fragment profile menu item click #359

kareemradwan commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

kareemradwan commented Sep 11, 2020

jdkoren left a comment

kareemradwan commented Sep 11, 2020

kareemradwan commented Sep 13, 2020

jdkoren Sep 14, 2020

jdkoren Sep 15, 2020

jdkoren Oct 23, 2020

jdkoren Oct 23, 2020

jdkoren Oct 23, 2020

jdkoren Oct 23, 2020

jdkoren Oct 23, 2020

jdkoren Oct 23, 2020

fix info and setting fragment profile menu item click #359

Are you sure you want to change the base?

fix info and setting fragment profile menu item click #359

Conversation

kareemradwan commented Sep 11, 2020

google-cla bot commented Sep 11, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

kareemradwan commented Sep 11, 2020

jdkoren left a comment

Choose a reason for hiding this comment

kareemradwan commented Sep 11, 2020

kareemradwan commented Sep 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment