Skip to content

Commit

Permalink
Removed Automatic-Module-Name from carrier and geocoder... (#3758)
Browse files Browse the repository at this point in the history
* Added Automatic-Module-Name to published jars. Context: https://b.corp.google.com/issues/308334884

* Removed Automatic-Module-Name from carrier and geocoder. Classes in these modules belong to the same package as core libphonenumber library, which leads to the split package problem with Java modules.
  • Loading branch information
tvislavski authored Dec 12, 2024
1 parent 462cea9 commit 9fc0f28
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions java/carrier/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@
<manifestFile>
${project.build.outputDirectory}/META-INF/MANIFEST.MF
</manifestFile>
<manifestEntries>
<Automatic-Module-Name>com.google.i18n.phonenumbers.carrier
</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</execution>
Expand Down
4 changes: 0 additions & 4 deletions java/geocoder/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@
<manifestFile>
${project.build.outputDirectory}/META-INF/MANIFEST.MF
</manifestFile>
<manifestEntries>
<Automatic-Module-Name>com.google.i18n.phonenumbers.geocoder
</Automatic-Module-Name>
</manifestEntries>
</archive>
</configuration>
</execution>
Expand Down

0 comments on commit 9fc0f28

Please sign in to comment.