Add "()" when string.match() is executed in js

[SG-Kang]

Without "()", when many conditions exist and former one is matched, it returns the wrong value. So adding "()" for the regex

I think it doesn't happen in Java and cpp

[related issue] (raised by myself)
https://issuetracker.google.com/issues/383824582

[java]
https://github.com/google/libphonenumber/blob/master/java/libphonenumber/src/com/google/i18n/phonenumbers/internal/RegexBasedMatcher.java#L49-L56

[cpp]
https://github.com/google/libphonenumber/blob/master/cpp/src/phonenumbers/regex_based_matcher.cc#L51-L65

[mandlil]

Hi,

Thank you for contributing to libphonenumber!

We tested with your PR changes, internally we are getting testcase failures for the string type phonenumbers.
Instead of writing changes in matchEntirely function, you can write here(

libphonenumber/javascript/i18n/phonenumbers/phonenumberutil.js

Line 3855 in 4246175

new RegExp(generalDesc.getNationalNumberPatternOrDefault());

) like new RegExp('^(?:' + generalDesc.getNationalNumberPatternOrDefault() + ')$').

[SG-Kang]

Hi,

Thank you for contributing to libphonenumber!

We tested with your PR changes, internally we are getting testcase failures for the string type phonenumbers. Instead of writing changes in matchEntirely function, you can write here(

libphonenumber/javascript/i18n/phonenumbers/phonenumberutil.js

Line 3855 in 4246175

new RegExp(generalDesc.getNationalNumberPatternOrDefault());

) like new RegExp('^(?:' + generalDesc.getNationalNumberPatternOrDefault() + ')$').

Hello,
Thank you for your thoughtful review.
While testing with the test cases in this repository, I noticed that a Russian uppercase phone number was incorrectly identified as an invalid number. To address this, I added a case-insensitive option to the regular expression, and all test cases passed successfully.
I also saw your PR (#3770). I think addressing the root cause by modifying the "matchesEntirely" function might be necessary since it is called from multiple places. However, if your proposed change adequately resolves the issue, I think your approach is also a good solution.