Upgraded to a version of etcd compatible with newer grpc #2376
Conversation
Trillian has been stuck on grpc < 1.30 - google#2195. This uses the v3 version of etcd which isn't using the experimental (and now deleted) grpc APIs I've deleted the prometheus etcdiscover tool in this commit. This can be re-added if we believe it's used, and we can find a way to test it. The upgrade path for this looks non-trivial.
Codecov Report
@@ Coverage Diff @@
## master #2376 +/- ##
==========================================
+ Coverage 65.94% 65.99% +0.05%
==========================================
Files 108 108
Lines 7869 7869
==========================================
+ Hits 5189 5193 +4
+ Misses 2134 2130 -4
Partials 546 546
Continue to review full report at Codecov.
|
|
"integration_etcd" step fails because of |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // The etcdiscover binary monitors etcd to track the set of instances that |
There was a problem hiding this comment.
We do not run etcdiscover. In our environment we have kubernetes prometheus-operator find everything with some specific etcd label. Thank you for asking and looking out for us!
There was a problem hiding this comment.
This seems promising then. I thought we might need this tool but was just deleting it to test whether the rest of the changes would fly first. If we don't know of any users, then maybe deleting it and then allowing it to be resurrected by someone with motivation & knowledge isn't a bad call.
There was a problem hiding this comment.
It was definitely used at one point to hook up monitoring. I thought it was used in our cloud deployment as well. Maybe things have changed under it and it no longer is.
|
After submitting, could you please check that Trillian&etcd can be upgraded in ct-go accordingly? There is a dependency if I remember correctly. |
|
Also, please indicate the etcd&grpc upgrade in the CHANGELOG. |
Trillian has been stuck on grpc < 1.30 - #2195. This uses the v3 version of etcd which isn't using the experimental (and now deleted) grpc APIs
I've deleted the prometheus etcdiscover tool in this commit. This can be re-added if we believe it's used, and we can find a way to test it. The upgrade path for this looks non-trivial.
Checklist