feat: add StdOutLogger and LoggingTrait #578
Conversation
bshaffer
changed the title
Hectorhammett
force-pushed
the
http-logging
branch
from
4122fb0
to
6370690
Compare
| $requestEvent->retryAttempt = $options['retryAttempt'] ?? null; | ||
| $requestEvent->serviceName = $options['serviceName'] ?? null; | ||
| $requestEvent->clientId = spl_object_id($this->client); | ||
| $requestEvent->requestId = spl_object_id($request); |
There was a problem hiding this comment.
since this code is duplicated above, why not have private methods like logHttpRequest($request) and logHttpResponse($response, $requestEvent)?
There was a problem hiding this comment.
In my mind, formatting the LogEvent and filling that data is not duty of the log function. The log function takes the generic log object and turns it into a json string to the docs specification, that's why I decided to have this code "duplicated", which in my mind is not really "duplicated" but is basically the same, mostly because one is for the response and one is for the request, and I did it this way in order to keep them separate from the logging logic.
I also thought perhaps a function to make a logEvent but voted against it as it would have to be flexible enough to acomodate the small differences between response and request but it can definitely be done.
Hectorhammett
force-pushed
the
http-logging
branch
from
016dad1
to
706982b
Compare
Hectorhammett
force-pushed
the
http-logging
branch
from
de8b6ff
to
db765ec
Compare
related: googleapis/gax-php#585
Add logging support to the HTTP calls for easy debugging.