Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Use Google.Api.Generator from a dotnet tool #13414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Aug 14, 2024

No description provided.

@jskeet jskeet added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 14, 2024
@jskeet jskeet requested a review from a team as a code owner August 14, 2024 14:31
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

}
},
"Google.Api.Generator": {
"version": "1.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had 1.4.32 before...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I figured that we'd make the first release as a dotnet tool 1.5.0. But that's very much up for debate :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fine by me, just in case it was left over from you trying things locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants