Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [Google.Cloud.BigQuery.Reservation.V1] Add the managed disaster recovery API(https://cloud.google.com/bigquery/docs/managed-disaster-recovery) #13901

Merged

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 3, 2024

  • Regenerate this pull request now.

feat: Add a new field is_flat_rate to .google.cloud.bigquery.reservation.v1.CapacityCommitment to distinguish between flat rate and edition commitments
docs: Clarify that Autoscale.current_slots in message .google.cloud.bigquery.reservation.v1.Reservation can temporarily be larger than Autoscale.max_slots if users reduce Autoscale.max_slots
docs: Update comment for slot_capacity in message .google.cloud.bigquery.reservation.v1.Reservation to provide more clarity about reservation baselines, committed slots and autoscaler SKU charges when the baseline exceeds committed slots
docs: Update comments for commitment_start_time and commitment_end_time in message .google.cloud.bigquery.reservation.v1.CapacityCommitment to provide details on how these values are affected by commitment renewal

PiperOrigin-RevId: 702079972

Source-Link: googleapis/googleapis@4743cf9

Source-Link: https://github.com/googleapis/googleapis-gen/commit/30e936000bfab99bf2856bb846a50eb0ee0385b7
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQmlnUXVlcnkuUmVzZXJ2YXRpb24uVjEvLk93bEJvdC55YW1sIiwiaCI6IjMwZTkzNjAwMGJmYWI5OWJmMjg1NmJiODQ2YTUwZWIwZWUwMzg1YjcifQ==

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Pull request diff results
OwlBot post-processor has not run: failing diff.

…bigquery/docs/managed-disaster-recovery)

feat: Add a new field `is_flat_rate` to `.google.cloud.bigquery.reservation.v1.CapacityCommitment` to distinguish between flat rate and edition commitments
docs: Clarify that `Autoscale.current_slots` in message `.google.cloud.bigquery.reservation.v1.Reservation` can temporarily be larger than `Autoscale.max_slots` if users reduce `Autoscale.max_slots`
docs: Update comment for `slot_capacity` in message `.google.cloud.bigquery.reservation.v1.Reservation` to provide more clarity about reservation baselines, committed slots and autoscaler SKU charges when the baseline exceeds committed slots
docs: Update comments for `commitment_start_time` and `commitment_end_time` in message `.google.cloud.bigquery.reservation.v1.CapacityCommitment` to provide details on how these values are affected by commitment renewal

PiperOrigin-RevId: 702079972

Source-Link: googleapis/googleapis@4743cf9

Source-Link: googleapis/googleapis-gen@30e9360
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQmlnUXVlcnkuUmVzZXJ2YXRpb24uVjEvLk93bEJvdC55YW1sIiwiaCI6IjMwZTkzNjAwMGJmYWI5OWJmMjg1NmJiODQ2YTUwZWIwZWUwMzg1YjcifQ==
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 3, 2024 01:14
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner December 3, 2024 01:14
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-apis-Google_Cloud_BigQuery_Reservation_V1 branch from db26b29 to 71d77b1 Compare December 3, 2024 01:14
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 3, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 3, 2024
Copy link

snippet-bot bot commented Dec 3, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

github-actions bot commented Dec 3, 2024

Pull request diff results
Finding changes in Google.Cloud.BigQuery.Reservation.V1...
Comparing old and new versions (by source)
Minor changes:
Class 'CapacityCommitment'; property 'Boolean IsFlatRate { get; set; }' added.
Class 'CapacityCommitment'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.CapacityCommitment::IsFlatRateFieldNumber' added.
Class 'FailoverReservationRequest' added.
Class 'Reservation'; property 'LocationName OriginalPrimaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'LocationName PrimaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'LocationName SecondaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'String OriginalPrimaryLocation { get; set; }' added.
Class 'Reservation'; property 'String PrimaryLocation { get; set; }' added.
Class 'Reservation'; property 'String SecondaryLocation { get; set; }' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::OriginalPrimaryLocationFieldNumber' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::PrimaryLocationFieldNumber' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::SecondaryLocationFieldNumber' added.
Class 'ReservationService.ReservationServiceBase'; method 'Task FailoverReservation(FailoverReservationRequest request, ServerCallContext context)' added.
Class 'ReservationService.ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallOptions options)' added.
Class 'ReservationService.ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'ReservationService.ReservationServiceClient'; method 'AsyncUnaryCall FailoverReservationAsync(FailoverReservationRequest request, CallOptions options)' added.
Class 'ReservationService.ReservationServiceClient'; method 'AsyncUnaryCall FailoverReservationAsync(FailoverReservationRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClient'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClient'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CancellationToken cancellationToken)' added.
Class 'ReservationServiceClientImpl'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClientImpl'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceSettings'; property 'CallSettings FailoverReservationSettings { get; set; }' added.

Diff level: Minor

Comparing with previous NuGet package
Checking compatibility for Google.Cloud.BigQuery.Reservation.V1 version 2.5.0
Differences from 2.5.0
Minor changes:
Class 'CapacityCommitment'; property 'Boolean IsFlatRate { get; set; }' added.
Class 'CapacityCommitment'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.CapacityCommitment::IsFlatRateFieldNumber' added.
Class 'FailoverReservationRequest' added.
Class 'Reservation'; property 'LocationName OriginalPrimaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'LocationName PrimaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'LocationName SecondaryLocationAsLocationName { get; set; }' added.
Class 'Reservation'; property 'String OriginalPrimaryLocation { get; set; }' added.
Class 'Reservation'; property 'String PrimaryLocation { get; set; }' added.
Class 'Reservation'; property 'String SecondaryLocation { get; set; }' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::OriginalPrimaryLocationFieldNumber' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::PrimaryLocationFieldNumber' added.
Class 'Reservation'; constant 'System.Int32 Google.Cloud.BigQuery.Reservation.V1.Reservation::SecondaryLocationFieldNumber' added.
Class 'ReservationService.ReservationServiceBase'; method 'Task FailoverReservation(FailoverReservationRequest request, ServerCallContext context)' added.
Class 'ReservationService.ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallOptions options)' added.
Class 'ReservationService.ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'ReservationService.ReservationServiceClient'; method 'AsyncUnaryCall FailoverReservationAsync(FailoverReservationRequest request, CallOptions options)' added.
Class 'ReservationService.ReservationServiceClient'; method 'AsyncUnaryCall FailoverReservationAsync(FailoverReservationRequest request, Metadata headers = null, Nullable deadline = null, CancellationToken cancellationToken = null)' added.
Class 'ReservationServiceClient'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClient'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClient'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CancellationToken cancellationToken)' added.
Class 'ReservationServiceClientImpl'; method 'Reservation FailoverReservation(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceClientImpl'; method 'Task FailoverReservationAsync(FailoverReservationRequest request, CallSettings callSettings = null)' added.
Class 'ReservationServiceSettings'; property 'CallSettings FailoverReservationSettings { get; set; }' added.

Diff level: Minor

Finished comparisons for Google.Cloud.BigQuery.Reservation.V1

@amanda-tarafa amanda-tarafa merged commit 54897cb into main Dec 3, 2024
11 checks passed
@amanda-tarafa amanda-tarafa deleted the owl-bot-copy-apis-Google_Cloud_BigQuery_Reservation_V1 branch December 3, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant