Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify docker-compose environment format (#91) #92

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

eternal-flame-AD
Copy link
Member

Fixes #91

@eternal-flame-AD eternal-flame-AD requested a review from a team November 20, 2024 20:56
@eternal-flame-AD eternal-flame-AD self-assigned this Nov 20, 2024
docs/installation.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
Signed-off-by: eternal-flame-AD <[email protected]>
@eternal-flame-AD eternal-flame-AD merged commit 0185056 into master Nov 22, 2024
0 of 2 checks passed
@eternal-flame-AD
Copy link
Member Author

Seems like it is refusing to deploy because admin does not have escape characters in it. Is this lint really useful that you should prefer double quotes in YAML (I never do it and I think most people use single quotes unless they need \r \n to work

@jmattheis
Copy link
Member

I fixed the prettier stuff in a newer commit, it had single quotes configured but the file was in the wrong directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

docker compose environment variables encoded as KEY='value' are not longer accepted since 2.6
2 participants