Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge v2.0.3 changes to 6.x.x #9

Open
wants to merge 6 commits into
base: 6.x.x
Choose a base branch
from

Conversation

vsachinv
Copy link

@vsachinv vsachinv commented Dec 3, 2024

No description provided.

@matrei
Copy link
Collaborator

matrei commented Dec 4, 2024

@vsachinv Thank you for the PR.

From what I can see, this PR is adding publishing of release artifacts to Github Packages, is that right?

The Grails Team has just now done changes to the grails-gradle-plugin to simplify publishing and streamline that over all the Grails repositories (grails/grails-gradle-plugin#355).

We are about to update the project to this new functionality and can release 4.0.0 after that.

Is that ok with you?

@vsachinv
Copy link
Author

vsachinv commented Dec 4, 2024

@matrei Thats correct. Its for mainly Github Packages. Also, to have code changes from lower release streamlined to latest. If Grails-gradle-plugin getting streamline then no issues we can see if we don't want to have this change otherwise it could be good to have 🙂 I see that plugin would be available with Grails 7.x

@matrei
Copy link
Collaborator

matrei commented Dec 4, 2024

@vsachinv Yes, you are right, the changes to the grails-gradle-plugin is for Grails 7, so that does not have any bearing on this discussion.

However, from a maintenance perspective, I don't think it's a good idea to diverge in this project from what we are doing in other Grails Team managed repos.

Looking at #4, the reason that releasing to Github Packages was introduced, was because io.github.gradle-nexus.publish-plugin is not compatible with Gradle 3.5 (that is used in an older release branch).

As publishing with io.github.gradle-nexus.publish-plugin is not a problem for 6.x.x, I don't think it's necessary to add publishing to Github Packages in 6.x.x.

Would you like me to release 4.0.0?
As far as I can see, the only relevant changes on the 6.x.x branch is the the update to Grails 6 (Java 11), and the version update to the mail plugin.

@vsachinv
Copy link
Author

vsachinv commented Dec 4, 2024

@matrei Sure we can skip this PR. Yes, please publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants