Skip to content

Commit

Permalink
Merge pull request #56 from gpc/matrei/add-servlet-api
Browse files Browse the repository at this point in the history
fix(deps): set compileOnly dependencies
  • Loading branch information
codeconsole authored Oct 16, 2024
2 parents 7bd2507 + d16a00c commit da501c8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
9 changes: 6 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,18 @@ repositories {

dependencies {

api libs.groovy.core // Used in public api
compileOnly libs.grails.core // Used in public api, but provided
compileOnly libs.groovy.core // Used in public api, but provided
compileOnly libs.servlet.api // Provided

api libs.javamail.api // Used in public api
api libs.spring.context // Used in public api
api libs.spring.context.support // Used in public api

// These three libraries are used in public api, but not in a way
// These two libraries are used in public api, but not in a way
// that is meant to be consumed by users of the plugin.
// Therefore they are set to implementation to not expose unnecessarily
// to the compileClasspath of plugin users.
implementation libs.grails.core
implementation libs.grails.gsp
implementation libs.grails.web.common

Expand All @@ -40,6 +42,7 @@ dependencies {
implementation libs.springboot.autoconfigure

testImplementation libs.grails.testing.support.core
testImplementation libs.servlet.api
testImplementation libs.spock.core

integrationTestImplementation libs.groovy.xml
Expand Down
2 changes: 2 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ greenmail = '2.0.1'
groovy = '4.0.23'
gsp = '7.0.0-SNAPSHOT'
javamail = '2.0.1'
servlet-api = '6.0.0'
slf4j = '1.7.36'
spring = '6.1.13'
springboot = '3.3.4'
Expand All @@ -22,6 +23,7 @@ groovy-core = { module = 'org.apache.groovy:groovy', version.ref = 'groovy' }
grails-docs = { module = 'org.grails:grails-docs', version.ref = 'grails' }
groovy-templates = { module = 'org.apache.groovy:groovy-templates', version.ref = 'groovy' }
groovy-xml = { module = 'org.apache.groovy:groovy-xml', version.ref = 'groovy' }
servlet-api = { module = 'jakarta.servlet:jakarta.servlet-api', version.ref = 'servlet-api' }
javamail-api = { module = 'jakarta.mail:jakarta.mail-api', version.ref = 'javamail' }
javamail-impl = { module = 'com.sun.mail:jakarta.mail', version.ref = 'javamail' }
slf4j-nop = { module = 'org.slf4j:slf4j-nop', version.ref = 'slf4j' }
Expand Down

0 comments on commit da501c8

Please sign in to comment.