Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update Polyglot Chat README #258

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

olyagpl
Copy link
Member

@olyagpl olyagpl commented Feb 8, 2024

No description provided.

@olyagpl olyagpl requested a review from timfel February 8, 2024 16:19
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 8, 2024
@ghost
Copy link

ghost commented Feb 8, 2024

I don't think this should need an installation of graalpy. The current approach is to include graalpy in the dependencies--or is that not yet supported in Gradle?

@olyagpl
Copy link
Member Author

olyagpl commented Feb 9, 2024

@bhoran , you still need graalpy launcher to copy resources, to install the nltk module. As Tim F. explained in #253, Gradle build will not put the resources in the right place.

polyglot-chat-app/README.md Outdated Show resolved Hide resolved
Co-authored-by: Bernard Horan <[email protected]>
@olyagpl
Copy link
Member Author

olyagpl commented Feb 12, 2024

@bhoran , can you please test from your end following this updated README?

@olyagpl olyagpl requested a review from a user February 14, 2024 07:56
polyglot-chat-app/README.md Outdated Show resolved Hide resolved
polyglot-chat-app/README.md Outdated Show resolved Hide resolved
olyagpl and others added 4 commits February 14, 2024 10:41
Co-authored-by: Bernard Horan <[email protected]>
Co-authored-by: Bernard Horan <[email protected]>
This now produces a native executable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants