Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins DSL scripts for 20.1 branch, see #81 #82

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Jenkins DSL scripts for 20.1 branch, see #81 #82

merged 1 commit into from
Dec 22, 2020

Conversation

Karm
Copy link
Collaborator

@Karm Karm commented Dec 17, 2020

Just a port of #81

@Karm Karm requested a review from zakkak December 17, 2020 13:48
@Karm Karm self-assigned this Dec 17, 2020
@Karm Karm changed the base branch from master to 20.1 December 17, 2020 13:48
@Karm Karm changed the title 20.1 jenkins Jenkins DSL scritps for 20.1 branch, see #81 Dec 17, 2020
@zakkak zakkak changed the title Jenkins DSL scritps for 20.1 branch, see #81 Jenkins DSL scripts for 20.1 branch, see #81 Dec 17, 2020
@Karm Karm mentioned this pull request Dec 17, 2020
Merged
@zakkak
Copy link
Collaborator

zakkak commented Dec 17, 2020

Is this backport really necessary?

AFAIU the jenkins pipeline only needs the build scripts located under jenkins/jobs/scripts, do we need to backport the pipelines as well?

@Karm
Copy link
Collaborator Author

Karm commented Dec 17, 2020

Is this backport really necessary?

AFAIU the jenkins pipeline only needs the build scripts located under jenkins/jobs/scripts, do we need to backport the pipelines as well?

It is not necessary per se. It seemed more consistent to me to do it as 1:1 backport.

Per rule of thumb less code = better, I will remove the groovy files here...

@Karm
Copy link
Collaborator Author

Karm commented Dec 17, 2020

BTW: @zakkak Annoying lesson learned: Jenkins DSL != Jenkins Pipeline. The syntax looks vaguely similar, but these are two unrelated DSLs and looking at a guide/How-To for one does not help with the other.

@zakkak
Copy link
Collaborator

zakkak commented Dec 17, 2020 •
edited
Loading

Per rule of thumb less code = better, I will remove the groovy files here...

+1, I am mostly worried about inconsistencies between the groovy files across the two branches and potential confusion in the future.

BTW: @zakkak Annoying lesson learned: Jenkins DSL != Jenkins Pipeline. The syntax looks vaguely similar, but these are two unrelated DSLs and looking at a guide/How-To for one does not help with the other.

Good to know, thanks

@Karm
Copy link
Collaborator Author

Karm commented Dec 21, 2020

@zakkak ping,
It needs a review & merge to work for the builds....
Thx.

zakkak
zakkak approved these changes Dec 22, 2020
View reviewed changes
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Karm

@zakkak zakkak merged commit a4917ef into graalvm:20.1 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

Assignees

@Karm Karm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karm @zakkak