Make accessFilter file registration thread safe #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
melix
requested changes
Nov 4, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 4, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 4, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
olpaw
requested changes
Nov 4, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
olpaw
reviewed
Nov 5, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
OCA Required
dnestoro
force-pushed
the
dnestoro/MakeAccessFilterFileRegistrationThreadSafe
branch
from
3ae135b
to
cc19b6d
Compare
oracle-contributor-agreement
bot
added
OCA Verified
olpaw
previously approved these changes
Nov 12, 2024
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
common/utils/src/main/java/org/graalvm/buildtools/agent/AgentConfiguration.java
Outdated
Show resolved
Hide resolved
dnestoro
force-pushed
the
dnestoro/MakeAccessFilterFileRegistrationThreadSafe
branch
from
cc19b6d
to
84b16a3
Compare
olpaw
approved these changes
Nov 12, 2024
melix
approved these changes
Nov 12, 2024
dnestoro
deleted the
dnestoro/MakeAccessFilterFileRegistrationThreadSafe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #626
Described issue probably occurs in multi-threaded environment because the reported error throws
FileAlreadyExistsExceptioneven though we checked first that file doesn't exist.As per documentation of
java.nio.file.Files#createDirectory:Since we only care that directory with the given name exists, we can just catch and ignore
FileAlreadyExistsExceptionin this case.