Improve make_component.sh #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase? I merged a PR that made some changes to the script in question and re-enabled the part of the gate that checks the components. |
- "Exit immediately if a command exits with a non-zero status." (set -e) - Fix incorrect `rm -rf COMPONENT_DIR` and add user prompt before deleting directory - Suggest to run `mvn package` when simplelanguage.jar is not found - Use pushd/popd in favor of `cd $COMPONENT_DIR || exit 1` - Mark variables as `readonly` - Minor consistency fixes
|
Done! PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
make_component.shin the following ways:set -e)rm -rf COMPONENT_DIRand add user prompt before deleting directorymvn packagewhensimplelanguage.jaris not foundpushd/popdin favor ofcdreadonly