Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small bug when join src & api_prefix #10017

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

Chandler-Bing
Copy link
Contributor

Update client.py

Description

fix a samll bug, previous version will ignore root path. will cause error in some specifial way

before

import urllib
src = 'https://demo.com/root_path/'
api_prefix = '/gradio'
src_prefixed = urllib.parse.urljoin(src, api_prefix).rstrip("/") + "/"
print(src_prefixed)
# https://demo.com/gradio/

actually we want it to be
https://demo.com/root_path/gradio/

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

Update client.py
@Chandler-Bing Chandler-Bing changed the title Update client.py fix small bug when join src & api_prefix Nov 22, 2024
@freddyaboulton freddyaboulton enabled auto-merge (squash) November 25, 2024 17:58
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 25, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/248dc748610fa4b4d84a5dee3a276b7cdacabedd/gradio-5.6.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@248dc748610fa4b4d84a5dee3a276b7cdacabedd#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/248dc748610fa4b4d84a5dee3a276b7cdacabedd/gradio-client-1.8.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/248dc748610fa4b4d84a5dee3a276b7cdacabedd/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Nov 25, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio minor
gradio_client minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

fix small bug when join src & api_prefix

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton freddyaboulton merged commit a95fda1 into gradio-app:main Nov 25, 2024
22 checks passed
@Chandler-Bing Chandler-Bing deleted the patch-1 branch December 12, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants